netdev - Re: [RFC bpf-next 2/6] net: xdp: RX meta data infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebb20d0fe78180f2cb22d010f023f3c67ac846a2.camel@mellanox.com>
Date:   Wed, 27 Jun 2018 17:55:05 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "saeedm@....mellanox.co.il" <saeedm@....mellanox.co.il>,
        "brouer@...hat.com" <brouer@...hat.com>
CC:     "alexander.h.duyck@...el.com" <alexander.h.duyck@...el.com>,
        "peter.waskiewicz.jr@...el.com" <peter.waskiewicz.jr@...el.com>,
        Rony Efraim <ronye@...lanox.com>,
        "borkmann@...earbox.net" <borkmann@...earbox.net>,
        Tariq Toukan <tariqt@...lanox.com>,
        "neerav.parikh@...el.com" <neerav.parikh@...el.com>,
        Opher Reviv <opher@...lanox.com>,
        "alexei.starovoitov@...il.com" <alexei.starovoitov@...il.com>,
        "pjwaskiewicz@...il.com" <pjwaskiewicz@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "ttoukan.linux@...il.com" <ttoukan.linux@...il.com>
Subject: Re: [RFC bpf-next 2/6] net: xdp: RX meta data infrastructure

On Wed, 2018-06-27 at 16:15 +0200, Jesper Dangaard Brouer wrote:
> On Tue, 26 Jun 2018 19:46:11 -0700
> Saeed Mahameed <saeedm@....mellanox.co.il> wrote:
> 
> > diff --git a/include/net/xdp.h b/include/net/xdp.h
> > index 2deea7166a34..afe302613ae1 100644
> > --- a/include/net/xdp.h
> > +++ b/include/net/xdp.h
> > @@ -138,6 +138,12 @@ xdp_set_data_meta_invalid(struct xdp_buff
> > *xdp)
> >  	xdp->data_meta = xdp->data + 1;
> >  }
> >  
> > +static __always_inline void
> > +xdp_reset_data_meta(struct xdp_buff *xdp)
> > +{
> > +	xdp->data_meta = xdp->data_hard_start;
> > +}
> 
> This is WRONG ... it should be:
> 
>  xdp->data_meta = xdp->data;
> 

maybe the name of the function is not suitable for the use case.
i need to set xdp->data_meta = xdp->data in the driver to start storing
meta data.