netdev - Re: [PATCH v1 net-next 02/14] net: Add a new socket option for a future transmit time.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <113cec18-2b12-f163-47fb-cd5a39b992a4@gmail.com>
Date:   Wed, 27 Jun 2018 17:05:50 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jesus Sanchez-Palencia <jesus.sanchez-palencia@...el.com>,
        Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org
Cc:     tglx@...utronix.de, jan.altenberg@...utronix.de,
        vinicius.gomes@...el.com, kurt.kanzenbach@...utronix.de,
        henrik@...tad.us, richardcochran@...il.com,
        ilias.apalodimas@...aro.org, ivan.khoronzhuk@...aro.org,
        mlichvar@...hat.com, willemb@...gle.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH v1 net-next 02/14] net: Add a new socket option for a
 future transmit time.



On 06/27/2018 04:07 PM, Jesus Sanchez-Palencia wrote:
 
> I'm failing to see how... There is a memset() in sock.c:1147 clearing all the 8
> bytes that we later use to (explicitly) assign each member of the struct. Aren't
> the 2 extra bytes sanitized, then? What have I missed?

Nothing, it seems I missed the memset(), it was not seen in the context of your patch
and I have not checked the whole function.