netdev - Re: [PATCH net 1/1] net/smc: rebuild nonblocking connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180628.220435.1811296249340213295.davem@davemloft.net>
Date:   Thu, 28 Jun 2018 22:04:35 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     ubraun@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        raspl@...ux.ibm.com, xiyou.wangcong@...il.com,
        eric.dumazet@...il.com
Subject: Re: [PATCH net 1/1] net/smc: rebuild nonblocking connect

From: Ursula Braun <ubraun@...ux.ibm.com>
Date: Wed, 27 Jun 2018 17:59:50 +0200

> The recent poll change may lead to stalls for non-blocking connecting
> SMC sockets, since sock_poll_wait is no longer performed on the
> internal CLC socket, but on the outer SMC socket.  kernel_connect() on
> the internal CLC socket returns with -EINPROGRESS, but the wake up
> logic does not work in all cases. If the internal CLC socket is still
> in state TCP_SYN_SENT when polled, sock_poll_wait() from sock_poll()
> does not sleep. It is supposed to sleep till the state of the internal
> CLC socket switches to TCP_ESTABLISHED.
> 
> This problem triggered a redesign of the SMC nonblocking connect logic.
> This patch introduces a connect worker covering all connect steps
> followed by a wake up of socket waiters. It allows to get rid of all
> delays and locks in smc_poll().
> 
> Fixes: c0129a061442 ("smc: convert to ->poll_mask")
> Signed-off-by: Ursula Braun <ubraun@...ux.ibm.com>

Applied.