netdev - Re: [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5e3b143-787f-436f-1d64-64cfc7d137a2@gmail.com>
Date:   Thu, 28 Jun 2018 09:50:08 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jakub.kicinski@...ronome.com,
        simon.horman@...ronome.com, john.hurley@...ronome.com,
        mlxsw@...lanox.com, sridhar.samudrala@...el.com
Subject: Re: [patch net-next v2 0/9] net: sched: introduce chain templates
 support with offloading to mlxsw

On 6/28/18 9:37 AM, Jiri Pirko wrote:
>>>>
>>>> Why this restriction? It's a template, so why can't it be removed
>>>> regardless of whether there are filters?
>>>
>>> That means you could start to insert filters that does not match the
>>> original template. I wanted to avoid it. The chain is utilized in hw for
>>> the original template, the filter insertion would have to be sanitized
>>> in driver. With this restriction, drivers can depend on filters always
>>> be fitting.
>>>
>>
>> Then the hardware driver should have that restriction not the core tc code.
> 
> But why? The same restriction would be in all drivers. I believe it is
> better to have in in tc in single place. Drivers can then depend on it.
> Do you have a usecase where you need to remove template for non-empty
> chain?
> 

If the hardware has the limitation then the driver should be rejecting a
change.