netdev - Re: [PATCH v3 bpf-net] bpf: Change bpf_fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f89aa491-b787-9a5b-dd6f-75a8e6486799@iogearbox.net>
Date:   Fri, 29 Jun 2018 00:08:38 +0200
From:   Daniel Borkmann <borkmann@...earbox.net>
To:     dsahern@...nel.org, netdev@...r.kernel.org, borkmann@...earbox.net,
        ast@...nel.org
Cc:     kafai@...com, brouer@...hat.com, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH v3 bpf-net] bpf: Change bpf_fib_lookup to return lookup
 status

On 06/27/2018 01:21 AM, dsahern@...nel.org wrote:
> From: David Ahern <dsahern@...il.com>
> 
> For ACLs implemented using either FIB rules or FIB entries, the BPF
> program needs the FIB lookup status to be able to drop the packet.
> Since the bpf_fib_lookup API has not reached a released kernel yet,
> change the return code to contain an encoding of the FIB lookup
> result and return the nexthop device index in the params struct.
> 
> In addition, inform the BPF program of any post FIB lookup reason as
> to why the packet needs to go up the stack.
> 
> The fib result for unicast routes must have an egress device, so remove
> the check that it is non-NULL.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied to bpf, thanks David!