netdev - Re: [PATCH 2/2] net: phy: DP83TC811: Fix SGMII enable/disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11cc30c2-271e-277c-ced2-c1faa334b11d@ti.com>
Date:   Thu, 28 Jun 2018 06:53:23 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <f.fainelli@...il.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] net: phy: DP83TC811: Fix SGMII enable/disable

Andrew

On 06/28/2018 03:20 AM, Andrew Lunn wrote:
> On Wed, Jun 27, 2018 at 01:16:18PM -0500, Dan Murphy wrote:
>> If SGMII was selected in the DT then the device should
>> write the SGMII enable bit.
>>
>> If SGMII is not selected in the DT then the SGMII bit
>> should be disabled.
>>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
>> ---
>>  arch/arm/configs/omap2plus_defconfig |  1 +
>>  drivers/net/phy/dp83tc811.c          | 20 +++++++++-----------
>>  2 files changed, 10 insertions(+), 11 deletions(-)
>>
>> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
>> index 06fb948ecfb3..30857d5b7a6c 100644
>> --- a/arch/arm/configs/omap2plus_defconfig
>> +++ b/arch/arm/configs/omap2plus_defconfig
>> @@ -182,6 +182,7 @@ CONFIG_TI_CPTS=y
>>  CONFIG_AT803X_PHY=y
>>  CONFIG_DP83848_PHY=y
>>  CONFIG_DP83867_PHY=y
>> +CONFIG_DP83TC811_PHY=y
>>  CONFIG_MICREL_PHY=y
>>  CONFIG_SMSC_PHY=y
>>  CONFIG_PPP=m
> 
> Hi Dan
> 
> This change does not belong here.
> 

Correct I will remove it.

>      Andrew
> 


-- 
------------------
Dan Murphy