netdev - Re: [PATCH v2 net-next 0/6] net sched actions: code style cleanup and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bc7c30bc912bfa28da4af6c2c5525cb8c5acf8f.camel@redhat.com>
Date:   Thu, 28 Jun 2018 14:26:38 +0200
From:   Davide Caratti <dcaratti@...hat.com>
To:     Roman Mashak <mrv@...atatu.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, kernel@...atatu.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH v2 net-next 0/6] net sched actions: code style cleanup
 and fixes

On Wed, 2018-06-27 at 13:33 -0400, Roman Mashak wrote:
> The patchset fixes a few code stylistic issues and typos, as well as one
> detected by sparse semantic checker tool.
> 
> No functional changes introduced.
> 
> Patch 1 & 2 fix coding style bits caught by the checkpatch.pl script
> Patch 3 fixes an issue with a shadowed variable
> Patch 4 adds sizeof() operator instead of magic number for buffer length
> Patch 5 fixes typos in diagnostics messages
> Patch 6 explicitly sets unsigned char for bitwise operation
> 
> v2:
>    - submit for net-next
>    - added Reviewed-by tags
>    - use u8* instead of char* as per Davide Caratti suggestion
> 
> Roman Mashak (6):
>   net sched actions: fix coding style in pedit action
>   net sched actions: fix coding style in pedit headers
>   net sched actions: fix sparse warning
>   net sched actions: use sizeof operator for buffer length
>   net sched actions: fix misleading text strings in pedit action
>   net sched actions: avoid bitwise operation on signed value in pedit
> 
>  include/net/tc_act/tc_pedit.h        |  1 +
>  include/uapi/linux/tc_act/tc_pedit.h |  9 ++++++--
>  net/sched/act_pedit.c                | 43 +++++++++++++++++++-----------------
>  3 files changed, 31 insertions(+), 22 deletions(-)
> 
for the series:

Acked-by: Davide Caratti <dcaratti@...hat.com>

regards,
-- 
davide