netdev - Re: [PATCH v12 03/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet Nexus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180629.111905.863023692523959153.davem@davemloft.net>
Date:   Fri, 29 Jun 2018 11:19:05 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     cmunoz@...ium.com
Cc:     andrew@...n.ch, steven.hill@...ium.com, netdev@...r.kernel.org,
        cchavva@...iumnetworks.com
Subject: Re: [PATCH v12 03/10] netdev: cavium: octeon: Add Octeon III BGX
 Ethernet Nexus

From: Carlos Munoz <cmunoz@...ium.com>
Date: Thu, 28 Jun 2018 14:20:05 -0700

> 
> 
> On 06/28/2018 01:41 AM, Andrew Lunn wrote:
>> External Email
>>
>>> +static char *mix_port;
>>> +module_param(mix_port, charp, 0444);
>>> +MODULE_PARM_DESC(mix_port, "Specifies which ports connect to MIX interfaces.");
>>> +
>>> +static char *pki_port;
>>> +module_param(pki_port, charp, 0444);
>>> +MODULE_PARM_DESC(pki_port, "Specifies which ports connect to the PKI.");
>> Module parameters are generally not liked. Can you do without them?
> 
> These parameters change the kernel port assignment required by user
> space applications. We rather keep them as they simplify the
> process.

This is actually a terrible user experience.

Please provide a way to do this by performing operations on a device object
after the driver loads.

Use something like devlink or similar if you have to.