netdev - Re: [PATCH net-next] strparser: Call skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180630.212558.1206392832287735000.davem@davemloft.net>
Date:   Sat, 30 Jun 2018 21:25:58 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     vakul.garg@....com
Cc:     netdev@...r.kernel.org, tom@...ntonium.net, borisp@...lanox.com,
        ebiggers@...gle.com, davejwatson@...com, doronrk@...com
Subject: Re: [PATCH net-next] strparser: Call skb_unclone conditionally

From: Vakul Garg <vakul.garg@....com>
Date: Sat, 30 Jun 2018 00:45:55 +0530

> Calling skb_unclone() is expensive as it triggers a memcpy operation.
> Instead of calling skb_unclone() unconditionally, call it only when skb
> has a shared frag_list. This improves tls rx throughout significantly.
> 
> Signed-off-by: Vakul Garg <vakul.garg@....com>
> Suggested-by: Boris Pismenny <borisp@...lanox.com>

Applied.