netdev - Re: [PATCH net] hv_netvsc: split sub-channel setup into async and sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180630.212930.58049848439397621.davem@davemloft.net>
Date:   Sat, 30 Jun 2018 21:29:30 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     haiyangz@...rosoft.com, haiyangz@...uxonhyperv.com
Cc:     netdev@...r.kernel.org, kys@...rosoft.com, sthemmin@...rosoft.com,
        olaf@...fle.de, vkuznets@...hat.com, devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] hv_netvsc: split sub-channel setup into async and
 sync

From: Haiyang Zhang <haiyangz@...uxonhyperv.com>
Date: Fri, 29 Jun 2018 14:07:16 -0700

> From: Stephen Hemminger <sthemmin@...rosoft.com>
> 
> When doing device hotplug the sub channel must be async to avoid
> deadlock issues because device is discovered in softirq context.
> 
> When doing changes to MTU and number of channels, the setup
> must be synchronous to avoid races such as when MTU and device
> settings are done in a single ip command.
> 
> Reported-by: Thomas Walker <Thomas.Walker@...sigma.com>
> Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
> Fixes: 732e49850c5e ("netvsc: fix race on sub channel creation")
> Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>

Applied and queued up for -stable.