netdev - Re: [PATCH net] tcp: fix Fast Open key endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180630.184238.1975481438159182115.davem@davemloft.net>
Date:   Sat, 30 Jun 2018 18:42:38 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     ycheng@...gle.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, ncardwell@...gle.com
Subject: Re: [PATCH net] tcp: fix Fast Open key endianness

From: Yuchung Cheng <ycheng@...gle.com>
Date: Wed, 27 Jun 2018 16:04:48 -0700

> Fast Open key could be stored in different endian based on the CPU.
> Previously hosts in different endianness in a server farm using
> the same key config (sysctl value) would produce different cookies.
> This patch fixes it by always storing it as little endian to keep
> same API for LE hosts.
> 
> Reported-by: Daniele Iamartino <danielei@...gle.com>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>

Applied and queued up for -stable.