netdev - RE: [net] fq_codel: fix NULL pointer deref in fq_codel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02874ECE860811409154E81DA85FBB5884BDDA2B@ORSMSX115.amr.corp.intel.com>
Date:   Mon, 2 Jul 2018 23:27:58 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
CC:     "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "jogreene@...hat.com" <jogreene@...hat.com>,
        "Eric Dumazet" <edumazet@...gle.com>
Subject: RE: [net] fq_codel: fix NULL pointer deref in fq_codel_reset

> -----Original Message-----
> From: Cong Wang [mailto:xiyou.wangcong@...il.com]
> Sent: Monday, June 11, 2018 1:23 PM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; davem@...emloft.net;
> netdev@...r.kernel.org; nhorman@...hat.com; sassmann@...hat.com;
> jogreene@...hat.com; Eric Dumazet <edumazet@...gle.com>
> Subject: Re: [net] fq_codel: fix NULL pointer deref in fq_codel_reset
> 
> On Mon, Jun 11, 2018 at 12:57 PM, Keller, Jacob E
> <jacob.e.keller@...el.com> wrote:
> >
> > I'm open to alternative suggestinos for fixing this, I think Eric suggested that
> maybe we should just remove the ->reset() call from qdisc_destroy..?
> 
> You can't remove ->reset() for non-failure call path.
> 
> For failure path, yeah, but it is much simpler to just make
> q->flows_cnt be 0 for this specific case.

Alright. I'll rework the patch to set flows_cnt to 0 when init fails.

Thanks,
Jake