netdev - Re: [PATCH bpf] bpf: hash_map: decrement counter on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180703202849.dydvuwcc6bcvy57i@ast-mbp.dhcp.thefacebook.com>
Date:   Tue, 3 Jul 2018 13:28:50 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Mauricio Vasquez <mauricio.vasquez@...ito.it>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH bpf] bpf: hash_map: decrement counter on error

On Sun, Jul 01, 2018 at 11:33:58AM -0500, Mauricio Vasquez wrote:
> 
> On 06/30/2018 06:20 PM, Daniel Borkmann wrote:
> > On 06/29/2018 02:48 PM, Mauricio Vasquez B wrote:
> > > Decrement the number of elements in the map in case the allocation
> > > of a new node fails.
> > > 
> > > Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@...ito.it>
> > Thanks for the fix, Mauricio!
> > 
> > Could you reply with a Fixes: tag in order to track the commit originally
> > introducing this bug?
> > 
> > Thanks,
> > Daniel
> > 
> 
> Sure Daniel,
> 
> Fixes: 6c9059817432 ("bpf: pre-allocate hash map elements")

Good catch. Thanks for the fix.
Acked-by: Alexei Starovoitov <ast@...nel.org>