netdev - Re: [PATCHv2 net-next 0/5] sctp: fully support for dscp and flowlabel per transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180703105053.GA20268@hmswarspite.think-freely.org>
Date:   Tue, 3 Jul 2018 06:50:53 -0400
From:   Neil Horman <nhorman@...driver.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        davem@...emloft.net, hideaki.yoshifuji@...aclelinux.com
Subject: Re: [PATCHv2 net-next 0/5] sctp: fully support for dscp and
 flowlabel per transport

On Mon, Jul 02, 2018 at 06:21:10PM +0800, Xin Long wrote:
> Now dscp and flowlabel are set from sock when sending the packets,
> but being multi-homing, sctp also supports for dscp and flowlabel
> per transport, which is described in section 8.1.12 in RFC6458.
> 
> v1->v2:
>   - define ip_queue_xmit as inline in net/ip.h, instead of exporting
>     it in Patch 1/5 according to David's suggestion.
>   - fix the param len check in sctp_s/getsockopt_peer_addr_params()
>     in Patch 3/5 to guarantee that an old app built with old kernel
>     headers could work on the newer kernel per Marcelo's point.
> 
> Xin Long (5):
>   ipv4: add __ip_queue_xmit() that supports tos param
>   sctp: add support for dscp and flowlabel per transport
>   sctp: add spp_ipv6_flowlabel and spp_dscp for sctp_paddrparams
>   sctp: add support for setting flowlabel when adding a transport
>   sctp: check for ipv6_pinfo legal sndflow with flowlabel in
>     sctp_v6_get_dst
> 
>  include/linux/sctp.h       |   7 ++
>  include/net/ip.h           |   9 ++-
>  include/net/sctp/structs.h |   9 +++
>  include/uapi/linux/sctp.h  |   4 +
>  net/ipv4/ip_output.c       |   9 ++-
>  net/sctp/associola.c       |  15 ++++
>  net/sctp/ipv6.c            |  20 ++++-
>  net/sctp/protocol.c        |  16 +++-
>  net/sctp/socket.c          | 182 +++++++++++++++++++++++++++++++++++++++++++--
>  9 files changed, 254 insertions(+), 17 deletions(-)
> 
> -- 
> 2.1.0
> 
> 
For the Series
Acked-by: Neil Horman <nhorman@...driver.com>