netdev - Re: [PATCH net-next v3 0/5] net: aquantia: various ethtool ops implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180703.232405.355892924699732095.davem@davemloft.net>
Date:   Tue, 03 Jul 2018 23:24:05 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     igor.russkikh@...antia.com
Cc:     netdev@...r.kernel.org, darcari@...hat.com,
        pavel.belous@...antia.com
Subject: Re: [PATCH net-next v3 0/5] net: aquantia: various ethtool ops
 implementation

From: Igor Russkikh <igor.russkikh@...antia.com>
Date: Mon,  2 Jul 2018 17:03:34 +0300

> In this patchset Anton Mikaev and I added some useful ethtool operations:
> - ring size changes
> - link renegotioation
> - flow control management
> 
> The patch also improves init/deinit sequence.
> 
> V3 changes:
> - After review and analysis it is clear that rtnl lock (which is 
>   captured by default on ethtool ops) is enough to secure possible
>   overlapping of dev open/close. Thus, just dropping internal mutex.
> 
> V2 changes:
> - using mutex to secure simultaneous dev close/open
> - using state var to store/restore dev state

Series applied.