netdev - Re: [PATCH net-next] net: sched: act_pedit: fix possible memory leak in tcf_pedit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpX3X-Z596m=V5avh90ZXmcggPi7F+7V0VqEuA4YmvSyHg@mail.gmail.com>
Date:   Tue, 3 Jul 2018 21:30:57 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        Amir Vadai <amir@...ai.me>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: sched: act_pedit: fix possible memory leak
 in tcf_pedit_init()

On Tue, Jul 3, 2018 at 6:36 AM Wei Yongjun <weiyongjun1@...wei.com> wrote:
>
> 'keys_ex' is malloced by tcf_pedit_keys_ex_parse() in tcf_pedit_init()
> but not all of the error handle path free it, this may cause memory
> leak. This patch fix it.
>
> Fixes: 71d0ed7079df ("net/act_pedit: Support using offset relative to the conventional network headers")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Acked-by: Cong Wang <xiyou.wangcong@...il.com>