netdev - Re: [PATCH v2 net] net/ipv6: Revert attempt to simplify route replace and append

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180704.152752.975782231140799917.davem@davemloft.net>
Date:   Wed, 04 Jul 2018 15:27:52 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, idosch@...lanox.com,
        sharpd@...ulusnetworks.com, Thomas.Winter@...iedtelesis.co.nz,
        petrm@...lanox.com, dsahern@...il.com
Subject: Re: [PATCH v2 net] net/ipv6: Revert attempt to simplify route
 replace and append

From: dsahern@...nel.org
Date: Tue,  3 Jul 2018 14:36:21 -0700

> From: David Ahern <dsahern@...il.com>
> 
> NetworkManager likes to manage linklocal prefix routes and does so with
> the NLM_F_APPEND flag, breaking attempts to simplify the IPv6 route
> code and by extension enable multipath routes with device only nexthops.
> 
> Revert f34436a43092 and these followup patches:
> 6eba08c3626b ("ipv6: Only emit append events for appended routes").
> ce45bded6435 ("mlxsw: spectrum_router: Align with new route replace logic")
> 53b562df8c20 ("mlxsw: spectrum_router: Allow appending to dev-only routes")
> 
> Update the fib_tests cases to reflect the old behavior.
> 
> Fixes: f34436a43092 ("net/ipv6: Simplify route replace and appending into multipath route")
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied.

> The gre_multipath tests only exist in net-next. Those will need to be
> updated separately.

Ok, please send me the net-next update once this gets merged there.

Thanks.