netdev - Re: [PATCH net] net: mv __dev_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180705.094919.1111182514263672077.davem@davemloft.net>
Date:   Thu, 05 Jul 2018 09:49:19 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, sbrivio@...hat.com,
        xiyou.wangcong@...il.com
Subject: Re: [PATCH net] net: mv __dev_notify_flags from void to int

From: Hangbin Liu <liuhangbin@...il.com>
Date: Wed,  4 Jul 2018 14:29:46 +0800

> @@ -7062,8 +7073,7 @@ int dev_change_flags(struct net_device *dev, unsigned int flags)
>  		return ret;
>  
>  	changes = (old_flags ^ dev->flags) | (old_gflags ^ dev->gflags);
> -	__dev_notify_flags(dev, old_flags, changes);
> -	return ret;
> +	return __dev_notify_flags(dev, old_flags, changes);

By doing this, you will lose any error code returned from dev_open().
That is why we return 'ret' instead of plain '0' here.