netdev - Re: [PATCH v2 08/14] ravb: fix invalid context bug while calling auto-negotiation by ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a840dedf-d636-ace4-18b4-a08f4c6b5a1e@cogentembedded.com>
Date:   Thu, 5 Jul 2018 11:27:51 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2 08/14] ravb: fix invalid context bug while calling
 auto-negotiation by ethtool

Hello!

On 7/5/2018 9:09 AM, Vladimir Zapolskiy wrote:

>> Since commit 35b5f6b1a82b ("PHYLIB: Locking fixes for PHY I/O
>> potentially sleeping") phy_start_aneg() function utilizes a mutex
>> to serialize changes to phy state, however the helper function is
>> called in atomic context.
>>
>> The bug can be reproduced by running "ethtool -r" command, the bug
>> is reported if CONFIG_DEBUG_ATOMIC_SLEEP build option is enabled.
>>
>> Fixes: a0d2f20650e8 ("Renesas Ethernet AVB PTP clock driver")
> 
> Here is an invalid commit specified, the proper tag is
> 
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")

    I was just going to tell you that. :-)
> --
> Best wishes,
> Vladimir

MBR, Sergei