netdev - Re: [PATCH] net: ethernet: sun: remove redundant variables adv and lpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22739fd9-1538-9abf-bfbe-5467196b4acf@canonical.com>
Date:   Thu, 5 Jul 2018 10:54:51 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: sun: remove redundant variables adv and
 lpa

On 05/07/18 10:52, Dan Carpenter wrote:
> On Thu, Jul 05, 2018 at 10:37:32AM +0100, Colin King wrote:
>> diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c
>> index 88c12474a0c3..2d6b62c6d9ab 100644
>> --- a/drivers/net/ethernet/sun/niu.c
>> +++ b/drivers/net/ethernet/sun/niu.c
>> @@ -1225,17 +1225,13 @@ static int link_status_1g_rgmii(struct niu *np, int *link_up_p)
>>  
>>  	bmsr = err;
>>  	if (bmsr & BMSR_LSTATUS) {
>> -		u16 adv, lpa;
>> -
>>  		err = mii_read(np, np->phy_addr, MII_ADVERTISE);
>>  		if (err < 0)
>>  			goto out;
>> -		adv = err;
>>  
>>  		err = mii_read(np, np->phy_addr, MII_LPA);
>>  		if (err < 0)
>>  			goto out;
>> -		lpa = err;
> 
> I'm fairly sure we could get rid of the mii_read() calls as well.

I'm always concerned that removing the reads of H/W registers can affect
the behavior, so I left those in.

Colin

> 
> regards,
> dan carpenter
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>