netdev - [PATCH] ieee802154: mcr20a: add missing includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f05de56e-eb0c-a821-b623-90571c4551de@datenfreihafen.org>
Date:   Thu, 5 Jul 2018 11:57:52 +0200
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Arnd Bergmann <arnd@...db.de>, Xue Liu <liuxuenetmail@...il.com>,
        Alexander Aring <alex.aring@...il.com>,
        Stefan Schmidt <stefan@....samsung.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Colin Ian King <colin.king@...onical.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] ieee802154: mcr20a: add missing includes

Hello.

[Sorry for the delay here, I was on a few weeks on leave]

On 30.05.2018 23:47, Arnd Bergmann wrote:
> Without CONFIG_GPIOLIB, some headers are not included implicitly,
> leading to a build failure:
> 
> drivers/net/ieee802154/mcr20a.c: In function 'mcr20a_probe':
> drivers/net/ieee802154/mcr20a.c:1347:13: error: implicit declaration of function 'irq_get_trigger_type'; did you mean 'irq_get_irqchip_state'? [-Werror=implicit-function-declaration]
> 
> This includes gpio/consumer.h and irq.h directly rather through the
> gpiolib header.
> 
> Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/ieee802154/mcr20a.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
> index de0d7f28a181..e428277781ac 100644
> --- a/drivers/net/ieee802154/mcr20a.c
> +++ b/drivers/net/ieee802154/mcr20a.c
> @@ -15,10 +15,11 @@
>   */
>  #include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/spi/spi.h>
>  #include <linux/workqueue.h>
>  #include <linux/interrupt.h>
> +#include <linux/irq.h>
>  #include <linux/skbuff.h>
>  #include <linux/of_gpio.h>
>  #include <linux/regmap.h>
> 

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt