netdev - Re: [PATCH net] net/ipv6: Revert attempt to simplify route replace and append

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180705.112935.1655283984550635892.davem@davemloft.net>
Date:   Thu, 05 Jul 2018 11:29:35 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     dsahern@...il.com, dsahern@...nel.org, netdev@...r.kernel.org,
        sharpd@...ulusnetworks.com, Thomas.Winter@...iedtelesis.co.nz,
        petrm@...lanox.com
Subject: Re: [PATCH net] net/ipv6: Revert attempt to simplify route replace
 and append

From: Ido Schimmel <idosch@...lanox.com>
Date: Thu, 5 Jul 2018 00:10:41 +0300

> We can have the IPv4/IPv6 code only generate a REPLACE / DELETE
> notification for routes that are actually used for forwarding and
> relieve listeners from the need to implement this logic themselves. I
> think this should work.

Whilst this could reduce the duplication, I worry that in the long
term that this might end up being error prone.

Just my $0.02