netdev - Re: [PATCH] ipv4: Return EINVAL when ping_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180706.115213.1244805309957477961.davem@davemloft.net>
Date:   Fri, 06 Jul 2018 11:52:13 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     tyhicks@...onical.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        ebiederm@...ssion.com, segoon@...nwall.com, netdev@...r.kernel.org,
        containers@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv4: Return EINVAL when ping_group_range sysctl
 doesn't map to user ns

From: Tyler Hicks <tyhicks@...onical.com>
Date: Thu,  5 Jul 2018 18:49:23 +0000

> The low and high values of the net.ipv4.ping_group_range sysctl were
> being silently forced to the default disabled state when a write to the
> sysctl contained GIDs that didn't map to the associated user namespace.
> Confusingly, the sysctl's write operation would return success and then
> a subsequent read of the sysctl would indicate that the low and high
> values are the overflowgid.
> 
> This patch changes the behavior by clearly returning an error when the
> sysctl write operation receives a GID range that doesn't map to the
> associated user namespace. In such a situation, the previous value of
> the sysctl is preserved and that range will be returned in a subsequent
> read of the sysctl.
> 
> Signed-off-by: Tyler Hicks <tyhicks@...onical.com>

Looks good to me, applied and queued up for -stable.

Thanks.