netdev - Re: [PATCH wpan 1/2] net: 6lowpan: fix reserved space for single frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e52e138-dd3c-de39-2bf7-09abd1314f3c@datenfreihafen.org>
Date:   Fri, 6 Jul 2018 10:07:09 +0200
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     David Palma <david.palma@...u.no>,
        Alexander Aring <aring@...atatu.com>, stefan@....samsung.com
Cc:     linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        kernel@...atatu.com,
        Rabi Narayan Sahoo <rabinarayans0828@...il.com>
Subject: Re: [PATCH wpan 1/2] net: 6lowpan: fix reserved space for single
 frames

Hello David.

On 06.07.2018 09:54, David Palma wrote:
> Hi Stefan,
> 
> On 05/07/18 13:16, Stefan Schmidt wrote:
>> Hello.
>>
>> [CC David Palma and Rabi Narayan Sahoo]
>>
>> On 02.07.2018 22:32, Alexander Aring wrote:
>>> This patch fixes patch add handling to take care tail and headroom for
>>> single 6lowpan frames. We need to be sure we have a skb with the right
>>> head and tailroom for single frames. This patch do it by using
>>> skb_copy_expand() if head and tailroom is not enough allocated by upper
>>> layer.
>>>
>>> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195059
>>> Reported-by: David Palma <david.palma@...u.no>
>>> Reported-by: Rabi Narayan Sahoo <rabinarayans0828@...il.com>
>>> Signed-off-by: Alexander Aring <aring@...atatu.com>
>>
>> David, Rabi and you please test these two patches and verify that it
>> fixes the problems you have?
>>
>> regards
>> Stefan Schmidt
>>
> 
> The patches fix the problems!
> 
> I've tested them against different packet sizes and no kernel panic.

Thanks for confirming.

> The patches were applied in Debian's 4.9.88-1+deb9u1 x86_64 kernel,
> which before the patches showed the reported issue.

I will see that I get them into the stable kernel as well. For LTS or
Debian kernels you might want to poke the maintainers of them directly
once this patch had hit Linux mainline.

regards
Stefan Schmidt