netdev - Re: [PATCH v4,net-next] vlan: implement vlan id and protocol changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 07 Jul 2018 20:11:16 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     3chas3@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v4,net-next] vlan: implement vlan id and protocol
 changes

From: Chas Williams <3chas3@...il.com>
Date: Mon,  2 Jul 2018 18:35:28 -0400

> vlan_changelink silently ignores attempts to change the vlan id
> or protocol id of an existing vlan interface.  Implement by adding
> the new vlan id and protocol to the interface's vlan group and then
> removing the old vlan id and protocol from the vlan group.  This
> avoids the netlink churn of deleting and re-adding an interface
> to change the vlan id.
> 
> Signed-off-by: Chas Williams <3chas3@...il.com>

Chas, it seems to me that you add the new notifier by not even one
driver is listening for the event.

Either it is necessary, and you should show at least one example
use case, or it not necessary and therefore should not be added.