netdev - Re: [net-next 1/1] tipc: extend link reset criteria for stale packet retransmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 07 Jul 2018 21:16:25 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org,
        mohan.krishna.ghanta.krishnamurthy@...csson.com,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next 1/1] tipc: extend link reset criteria for stale
 packet retransmission

From: Jon Maloy <jon.maloy@...csson.com>
Date: Fri, 6 Jul 2018 15:22:36 +0200

> Currently a link is declared stale and reset if there has been 100
> repeated attempts to retransmit the same packet. However, in certain
> infrastructures we see that packet (NACK) duplicates and delays may
> cause such retransmit attempts to occur at a high rate, so that the
> peer doesn't have a reasonable chance to acknowledge the reception
> before the 100-limit is hit. This may take much less than the
> stipulated link tolerance time, and despite that probe/probe replies
> otherwise go through as normal.
> 
> We now extend the criteria for link reset to also being time based.
> I.e., we don't reset the link until the link tolerance time is passed
> AND we have made 100 retransmissions attempts.
> 
> Acked-by: Ying Xue <ying.xue@...driver.com>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied, thanks Jon.