netdev - Re: [PATCH net 0/2] net/sched: fix NULL dereference in 'goto chain' control action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 07 Jul 2018 22:01:28 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     jiri@...nulli.us, amir@...ai.me, netdev@...r.kernel.org
Subject: Re: [PATCH net 0/2] net/sched: fix NULL dereference in 'goto
 chain' control action

From: Davide Caratti <dcaratti@...hat.com>
Date: Fri,  6 Jul 2018 21:01:04 +0200

> in a couple of TC actions (i.e. csum and tunnel_key), the control action
> is stored together with the action-specific configuration data.
> This avoids a race condition (see [1]), but it causes a crash when 'goto
> chain' is used with the above actions. Since this race condition is
> tolerated on the other TC actions (it's present even on actions where the
> spinlock is still used), storing the control action in the common area
> should be acceptable for tunnel_key and csum as well.
> 
> [1] https://www.spinics.net/lists/netdev/msg472047.html

Series applied and queued up for -stable, thanks Davide.