netdev - Re: [PATCH bpf] xdp: XDP_REDIRECT should check IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 7 Jul 2018 15:27:51 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH bpf] xdp: XDP_REDIRECT should check IFF_UP and MTU

On Fri, Jul 06, 2018 at 11:49:00AM +0900, Toshiaki Makita wrote:
> Otherwise we end up with attempting to send packets from down devices
> or to send oversized packets, which may cause unexpected driver/device
> behaviour. Generic XDP has already done this check, so reuse the logic
> in native XDP.
> 
> Fixes: 814abfabef3c ("xdp: add bpf_redirect helper function")
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Applied, Thanks