netdev - Re: [PATCH net-next] tcp: remove redundant SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180708.171531.22488752370800690.davem@davemloft.net>
Date:   Sun, 08 Jul 2018 17:15:31 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: remove redundant SOCK_DONE checks

From: Eric Dumazet <edumazet@...gle.com>
Date: Sat,  7 Jul 2018 23:15:56 -0700

> In both tcp_splice_read() and tcp_recvmsg(), we already test
> sock_flag(sk, SOCK_DONE) right before evaluating sk->sk_state,
> so "!sock_flag(sk, SOCK_DONE)" is always true.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Wow, I think this code has been like this since the initial GIT
import.

Applied, thanks.