netdev - Re: [PATCH net] net/ipv4: Set oif in fib_compute_spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180708.105535.754709207578413686.davem@davemloft.net>
Date:   Sun, 08 Jul 2018 10:55:35 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, lucien.xin@...il.com, dsahern@...il.com
Subject: Re: [PATCH net] net/ipv4: Set oif in fib_compute_spec_dst

From: dsahern@...nel.org
Date: Sat,  7 Jul 2018 16:15:26 -0700

> From: David Ahern <dsahern@...il.com>
> 
> Xin reported that icmp replies may not use the address on the device the
> echo request is received if the destination address is broadcast. Instead
> a route lookup is done without considering VRF context. Fix by setting
> oif in flow struct to the master device if it is enslaved. That directs
> the lookup to the VRF table. If the device is not enslaved, oif is still
> 0 so no affect.
> 
> Fixes: cd2fbe1b6b51 ("net: Use VRF device index for lookups on RX")
> Reported-by: Xin Long <lucien.xin@...il.com>
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable, thanks David.