netdev - Re: [PATCH v2 00/14] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efa424b3-1cf8-3eac-aea4-eaaef9df1b66@cogentembedded.com>
Date:   Mon, 9 Jul 2018 02:24:45 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     David Miller <davem@...emloft.net>
Cc:     vladimir_zapolskiy@...tor.com, andrew@...n.ch,
        geert@...ux-m68k.org, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2 00/14] ravb/sh_eth: fix sleep in atomic by reusing
 shared ethtool handlers

Hello!

On 7/8/2018 2:58 AM, David Miller wrote:

>>     So you applied the whole series to net.git... that was somewhat
>>     unexpected, at least by me. Care to share your reasoning?
> 
> It's fixes a sleep in atomic which is a serious bug.

    Do you realize that only patches 0, 1, 8, and 9 were real fixes, others 
were just follow-up cleanups? (Although the wording of the cover letter could 
have made people think that the whole series is the fixes...)
    OK, I understand what's done is done and it's not me that would have to 
justify the cleanups in a middle of the 4.18-rc's. But still, it was not a 
pleasant surprise (and I told Vladimir he shouldn't mix the real fixes and
cleanups in reply to his cover letter, IIRC).

MBR, Sergei