netdev - Re: [PATCH] net: sched: Fix warnings from xchg() on RCU'd cookie pointer.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <vbf1sccs4ff.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
Date:   Mon, 09 Jul 2018 20:29:56 +0300
From:   Vlad Buslov <vladbu@...lanox.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        jiri@...lanox.com
Subject: Re: [PATCH] net: sched: Fix warnings from xchg() on RCU'd cookie pointer.


On Mon 09 Jul 2018 at 15:30, Marcelo Ricardo Leitner <marcelo.leitner@...il.com> wrote:
> On Sun, Jul 08, 2018 at 05:03:58PM +0900, David Miller wrote:
>> 
>> The kbuild test robot reports:
>> 
>> >> net/sched/act_api.c:71:15: sparse: incorrect type in initializer (different address spaces) @@    expected struct tc_cookie [noderef] <asn:4>*__ret @@    got [noderef] <asn:4>*__ret @@
>>    net/sched/act_api.c:71:15:    expected struct tc_cookie [noderef] <asn:4>*__ret
>>    net/sched/act_api.c:71:15:    got struct tc_cookie *new_cookie
>> >> net/sched/act_api.c:71:13: sparse: incorrect type in assignment (different address spaces) @@    expected struct tc_cookie *old @@    got struct tc_cookie [noderef] <struct tc_cookie *old @@
>>    net/sched/act_api.c:71:13:    expected struct tc_cookie *old
>>    net/sched/act_api.c:71:13:    got struct tc_cookie [noderef] <asn:4>*[assigned] __ret
>
> This one:
>
>> >> net/sched/act_api.c:132:48: sparse: dereference of noderef expression
>
> Actually belongs to a different issue, that was reported in the same
> email, but which wasn't handled in this patch.
>
>   Marcelo

Thanks,

I've sent the fix.

Vlad