netdev - Re: [PATCH v2] rhashtable: add restart routine in rhashtable_free_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180709.162951.1992757585184071006.davem@davemloft.net>
Date:   Mon, 09 Jul 2018 16:29:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     tgraf@...g.ch, herbert@...dor.apana.org.au, netdev@...r.kernel.org,
        fw@...len.de, pablo@...filter.org
Subject: Re: [PATCH v2] rhashtable: add restart routine in
 rhashtable_free_and_destroy()

From: Taehee Yoo <ap420073@...il.com>
Date: Sun,  8 Jul 2018 11:55:51 +0900

> rhashtable_free_and_destroy() cancels re-hash deferred work
> then walks and destroys elements. at this moment, some elements can be
> still in future_tbl. that elements are not destroyed.
> 
> test case:
> nft_rhash_destroy() calls rhashtable_free_and_destroy() to destroy
> all elements of sets before destroying sets and chains.
> But rhashtable_free_and_destroy() doesn't destroy elements of future_tbl.
> so that splat occurred.
> 
> test script:
 ...
> Splat looks like:
 ...
> V2:
>  - free all tables requested by Herbert Xu
> 
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied and queued up for -stable.