netdev - Re: [PATCH net] net: diag: Don't double-free TCP_NEW_SYN_RECV sockets in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1acf7d5a-4465-120e-70bf-4fe24b1f7e3e@cumulusnetworks.com>
Date:   Mon, 9 Jul 2018 08:59:15 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Lorenzo Colitti <lorenzo@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Alistair Strachan <astrachan@...gle.com>,
        Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Subject: Re: [PATCH net] net: diag: Don't double-free TCP_NEW_SYN_RECV sockets
 in tcp_abort

On 7/8/18 10:53 PM, Lorenzo Colitti wrote:
> On Sat, Jul 7, 2018 at 10:29 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>>>> Tested: passes Android sock_diag_test.py, which exercises this codepath
>>>
>>> If this Android test case exercises this path, why didn't it trigger
>>> the double free and thus cause this bug to be found much sooner?
>>>
>>> Just curious.
>>
>> Presumably android has not backported yet the refcount_t stuff in their kernels.
> 
> That's correct. We only started seeing this on 4.14, which is not yet
> in the field.

Prior to 4.12 syn-recv sockets did not show up in the list, so it could
not be closed through the diag API. I did not chase it to a specific
commit between 4.11 (no syn-recv in 'ss -ta') and 4.12 (syn-recv shows
up in 'ss -ta').