netdev - Re: [net] sch_fq_codel: zero q->flows_cnt when fq_codel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWC0Zv=4RApRz9s3L9g-r=+FaYXbRrRx+s_GNLwk+9ekQ@mail.gmail.com>
Date:   Tue, 10 Jul 2018 13:32:26 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [net] sch_fq_codel: zero q->flows_cnt when fq_codel_init fails

On Mon, Jul 9, 2018 at 8:37 AM Jacob Keller <jacob.e.keller@...el.com> wrote:
> +alloc_failure:
> +       kfree(q->flows);

You need to call kvfree() instead.

Other than this,

Acked-by: Cong Wang <xiyou.wangcong@...il.com>

For net-next, I will send a patch to skip ->reset() for ->init() failure
case, there is no reason to reset queues since qdisc is not even
activated.