netdev - Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUzkSdCzxCH5VxNEN=OyXNOXeiFUNGD-XwrbNptxyRkNA@mail.gmail.com>
Date:   Tue, 10 Jul 2018 19:32:43 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     Michel Machado <michel@...irati.com.br>,
        Nishanth Devarajan <ndev2021@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Cody Doucette <doucette@...edu>
Subject: Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

On Mon, Jul 9, 2018 at 12:53 PM Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
>
> On Mon, Jul 09, 2018 at 02:18:33PM -0400, Michel Machado wrote:
> >
> >    2. sch_prio.c does not have a global limit on the number of packets on
> > all its queues, only a limit per queue.
>
> It can be useful to sch_prio.c as well, why not?
> prio_enqueue()
> {
> ...
> +       if (count > sch->global_limit)
> +               prio_tail_drop(sch);   /* to be implemented */
>         ret = qdisc_enqueue(skb, qdisc, to_free);
>

Isn't the whole point of sch_prio offloading the queueing to
each class? If you need a limit, there is one for each child
qdisc if you use for example pfifo or bfifo (depending on you
want to limit bytes or packets).

Also, what's your plan for backward compatibility here?