netdev - Re: [PATCH net-next] selftests: forwarding: mirror

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180710.225829.143333520309033405.davem@davemloft.net>
Date:   Tue, 10 Jul 2018 22:58:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     petrm@...lanox.com
Cc:     netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        shuah@...nel.org
Subject: Re: [PATCH net-next] selftests: forwarding: mirror_lib: Tighten up
 VLAN capture

From: Petr Machata <petrm@...lanox.com>
Date: Sun, 08 Jul 2018 19:58:55 +0200

> The function do_test_span_vlan_dir_ips() is used for testing whether
> mirrored packets are VLAN-encapsulated. But since it only considers
> VLAN encapsulation, it may end up matching unmirrored ARP traffic as
> well. One consequence is a rare failure of mirror_gre_vlan_bridge_1q's
> test_gretap_untagged_egress. Decreasing ping cadence in mirror_test()
> makes the problem easily reproducible.
> 
> Therefore tighten up the match criterion to only count those 802.1q
> packets where the next header is IP.
> 
> Signed-off-by: Petr Machata <petrm@...lanox.com>

Applied.