netdev - Re: [PATCH iproute2-next] ipaddress: fix label matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18bed3ed-4ad1-4506-6b80-62af9bd9e6d2@gmail.com>
Date:   Wed, 11 Jul 2018 21:01:19 -0400
From:   David Ahern <dsahern@...il.com>
To:     Vincent Bernat <vincent@...nat.im>, netdev@...r.kernel.org,
        stephen@...workplumber.org, serhe.popovych@...il.com
Subject: Re: [PATCH iproute2-next] ipaddress: fix label matching

On 7/11/18 7:36 AM, Vincent Bernat wrote:
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index 5009bfe6d2e3..20ef6724944e 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -837,11 +837,6 @@ int print_linkinfo(const struct sockaddr_nl *who,
>  	if (!name)
>  		return -1;
>  
> -	if (filter.label &&
> -	    (!filter.family || filter.family == AF_PACKET) &&
> -	    fnmatch(filter.label, name, 0))
> -		return -1;
> -

The offending commit changed the return code:

        if (filter.label &&
            (!filter.family || filter.family == AF_PACKET) &&
-           fnmatch(filter.label, RTA_DATA(tb[IFLA_IFNAME]), 0))
-               return 0;
+           fnmatch(filter.label, name, 0))
+               return -1;


Vincent: can you try leaving the code as is, but change the return to 0?