netdev - Re: [PATCH net-next v2 0/2] net/sched: act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180712.145427.1226587891063751899.davem@davemloft.net>
Date:   Thu, 12 Jul 2018 14:54:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     xiyou.wangcong@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/2] net/sched: act_skbedit: lockless data
 path

From: Davide Caratti <dcaratti@...hat.com>
Date: Wed, 11 Jul 2018 16:04:48 +0200

> the data path of act_skbedit can be faster if we avoid using spinlocks:
>  - patch 1 converts act_skbedit statistics to use per-cpu counters
>  - patch 2 lets act_skbedit use RCU to read/update its configuration 
> 
> test procedure (using pktgen from https://github.com/netoptimizer):
> 
>  # ip link add name eth1 type dummy
>  # ip link set dev eth1 up
>  # tc qdisc add dev eth1 clsact
>  # tc filter add dev eth1 egress matchall action skbedit priority c1a0:c1a0
>  # for c in 1 2 4 ; do
>  > ./pktgen_bench_xmit_mode_queue_xmit.sh -v -s 64 -t $c -n 5000000 -i eth1
>  > done
> 
> test results (avg. pps/thread)
> 
>   $c | before patch |  after patch | improvement
>  ----+--------------+--------------+------------
>    1 | 3917464 ± 3% | 4000458 ± 3% |  irrelevant
>    2 | 3455367 ± 4% | 3953076 ± 1% |        +14%
>    4 | 2496594 ± 2% | 3801123 ± 3% |        +52%
> 
> v2: rebased on latest net-next

Series applied, thank you.