netdev - Re: [PATCH net-next] net/sched: flower: Fix null pointer dereference when run tc vlan command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180711.224831.2104910551983464294.davem@davemloft.net>
Date:   Wed, 11 Jul 2018 22:48:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jianbol@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...nulli.us, zahari.doychev@...el.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com
Subject: Re: [PATCH net-next] net/sched: flower: Fix null pointer
 dereference when run tc vlan command

From: Jianbo Liu <jianbol@...lanox.com>
Date: Mon,  9 Jul 2018 02:26:20 +0000

> Zahari issued tc vlan command without setting vlan_ethtype, which will
> crash kernel. To avoid this, we must check tb[TCA_FLOWER_KEY_VLAN_ETH_TYPE]
> is not null before use it.
> Also we don't need to dump vlan_ethtype or cvlan_ethtype in this case.
> 
> Fixes: d64efd0926ba ('net/sched: flower: Add supprt for matching on QinQ vlan headers')
> Signed-off-by: Jianbo Liu <jianbol@...lanox.com>
> Reported-by: Zahari Doychev <zahari.doychev@...el.com>

Applied.