netdev - Re: [PATCH net 2/2] sfp: fix module initialisation with netdev already up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180711.231203.1203802251091215606.davem@davemloft.net>
Date:   Wed, 11 Jul 2018 23:12:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net 2/2] sfp: fix module initialisation with netdev
 already up

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Tue, 10 Jul 2018 12:05:36 +0100

> It was been observed that with a particular order of initialisation,
> the netdev can be up, but the SFP module still has its TX_DISABLE
> signal asserted.  This occurs when the network device brought up before
> the SFP kernel module has been inserted by userspace.
> 
> This occurs because sfp-bus layer does not hear about the change in
> network device state, and so assumes that it is still down.  Set
> netdev->sfp when the upstream is registered to work around this problem.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Applied.