netdev - Re: [PATCH net] skbuff: Unconditionally copy pfmemalloc in __skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180713124505.GA13363@bistromath.localdomain>
Date:   Fri, 13 Jul 2018 14:45:05 +0200
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Mel Gorman <mgorman@...e.de>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Patrick Talbert <ptalbert@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] skbuff: Unconditionally copy pfmemalloc in
 __skb_clone()

2018-07-13, 13:21:07 +0200, Stefano Brivio wrote:
> Commit 8b7008620b84 ("net: Don't copy pfmemalloc flag in
> __copy_skb_header()") introduced a different handling for the
> pfmemalloc flag in copy and clone paths.
> 
> In __skb_clone(), now, the flag is set only if it was set in the
> original skb, but not cleared if it wasn't. This is wrong and
> might lead to socket buffers being flagged with pfmemalloc even
> if the skb data wasn't allocated from pfmemalloc reserves. Copy
> the flag instead of ORing it.
> 
> Reported-by: Sabrina Dubroca <sd@...asysnail.net>
> Fixes: 8b7008620b84 ("net: Don't copy pfmemalloc flag in __copy_skb_header()")
> Signed-off-by: Stefano Brivio <sbrivio@...hat.com>

Thanks,

Tested-by: Sabrina Dubroca <sd@...asysnail.net>

-- 
Sabrina