netdev - Re: [PATCH iproute2-next 0/9] TC more JSON support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180713142942.49d24264@cakuba.lan>
Date:   Fri, 13 Jul 2018 14:29:42 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org, Stephen Hemminger <sthemmin@...rosoft.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH iproute2-next 0/9] TC more JSON support

On Fri, 13 Jul 2018 16:48:28 -0400, David Ahern wrote:
> On 7/9/18 3:48 PM, Stephen Hemminger wrote:
> > From: Stephen Hemminger <sthemmin@...rosoft.com>
> > 
> > Update core of TC command and library to do more JSON.
> > Most of this patch set is about getting tc utility functions
> > to be more friendly to the json_print infrastructure.
> > 
> > Stephen Hemminger (9):
> >   tc: use JSON in error handling
> >   tc: use const char in util
> >   tc: convert stats print to json
> >   tc/cbq: use sprint_rate
> >   tc/util: remove print_rate
> >   tc/util: remove unused print_size
> >   tc/util: remove unused print_time
> >   tc/util: add print helpers for JSON
> >   tc/sfq: add json support
> > 
> >  tc/q_cbq.c   | 15 ++++-----
> >  tc/q_sfq.c   | 65 +++++++++++++++++++++---------------
> >  tc/tc.c      | 19 ++++++-----
> >  tc/tc_util.c | 94 +++++++++++++++++++++++++++-------------------------
> >  tc/tc_util.h | 11 +++---
> >  5 files changed, 109 insertions(+), 95 deletions(-)
> >   
> 
> I'd prefer some tc folks to take a look at the json output and verify
> everything is good.
> 
> Jamal, Jiri, Jakub, Cong, others?
> 
> There is a second set with 30 patches as well.

AFAIK the 31 patches supersede this set?  I only have tests that use
JSON for MQ and RED qdiscs, and those work fine with the v2 applied!