netdev - Re: [PATCH bpf-next v5 0/3] bpf: btf: print bpftool map data with btf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e80f262-9b3f-e4ff-0e89-7a07098d1b50@iogearbox.net>
Date:   Sat, 14 Jul 2018 00:35:03 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Okash Khawaja <osk@...com>
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Martin KaFai Lau <kafai@...com>,
        Alexei Starovoitov <ast@...nel.org>,
        Yonghong Song <yhs@...com>,
        Quentin Monnet <quentin.monnet@...ronome.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-team@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v5 0/3] bpf: btf: print bpftool map data with btf

On 07/13/2018 11:35 PM, Okash Khawaja wrote:
> On Fri, Jul 13, 2018 at 10:49:01PM +0200, Daniel Borkmann wrote:
>> On 07/12/2018 05:30 AM, Jakub Kicinski wrote:
>>> On Wed, 11 Jul 2018 20:08:03 -0700, Okash Khawaja wrote:
>>>> Hi,
>>>>
>>>> Here are the changes from v4:
>>>>
>>>> patch 2:
>>>>
>>>> - sort headers in btf_dumper.c
>>>> - remove extra parentheses
>>>> - include asm/byteorder.h
>>>> - compile error when big and small endian bitfields macro undefined
>>>
>>> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>>
>> Hmm, strange, by accident I just noticed that only your bpf fix ever made
>> it to patchwork, Okash.
>>
>>   https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_project_netdev_list_-3Fsubmitter-3D74458-26state-3D-2A&d=DwICaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=4wHrS7MHHFLZe_WCJwRVhA&m=wkiBQFYWPyiN9WONHLY0WiZxcOwNRhXaMMLIE551mCA&s=RggQzClRdkwawboGLPgPXHOdUtYffxeOwlcBlFru-P4&e=
>>
>> Potentially because you've sent with attachments which got dropped on
>> the list?
> interesting because i send all patches using quilt mail, the same way i
> sent bpf fix. i can try git-send-email.
> 
> also i dropped Acked-by as i changed patch versions. is it common thing
> to do? or should i keep the Acked-by?

Depends on whether the pieces that have been ACKed changed in the
meantime or not.