netdev - Re: [PATCH] liquidio: Use %pad printk format for dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180713000648.GA3206@felix-thinkpad.cavium.com>
Date:   Thu, 12 Jul 2018 17:06:48 -0700
From:   Felix Manlunas <felix.manlunas@...ium.com>
To:     Helge Deller <deller@....de>
Cc:     Derek Chickles <derek.chickles@...iumnetworks.com>,
        Satanand Burla <satananda.burla@...iumnetworks.com>,
        Felix Manlunas <felix.manlunas@...iumnetworks.com>,
        Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>,
        netdev@...r.kernel.org, linux-parisc@...r.kernel.org
Subject: Re: [PATCH] liquidio: Use %pad printk format for dma_addr_t values

On Thu, Jul 12, 2018 at 10:36:29PM +0200, Helge Deller wrote:
> Use the existing %pad printk format to print dma_addr_t values.
> This avoids the following warnings when compiling on the parisc platform:
> 
> warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
> 
> Signed-off-by: Helge Deller <deller@....de>
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> index 1f2e75da28f8..d5d9e47daa4b 100644
> --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
> +++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> @@ -110,8 +110,8 @@ int octeon_init_instr_queue(struct octeon_device *oct,
> 
>  	memset(iq->request_list, 0, sizeof(*iq->request_list) * num_descs);
> 
> -	dev_dbg(&oct->pci_dev->dev, "IQ[%d]: base: %p basedma: %llx count: %d\n",
> -		iq_no, iq->base_addr, iq->base_addr_dma, iq->max_count);
> +	dev_dbg(&oct->pci_dev->dev, "IQ[%d]: base: %p basedma: %pad count: %d\n",
> +		iq_no, iq->base_addr, &iq->base_addr_dma, iq->max_count);
> 
>  	iq->txpciq.u64 = txpciq.u64;
>  	iq->fill_threshold = (u32)conf->db_min;

Acked-by: Felix Manlunas <felix.manlunas@...ium.com>