[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 13 Jul 2018 18:24:39 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: vladbu@...lanox.com
Cc: netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
jiri@...nulli.us
Subject: Re: [PATCH net-next] net: sched: refactor flower walk to iterate
over idr
From: Vlad Buslov <vladbu@...lanox.com>
Date: Mon, 9 Jul 2018 13:29:11 +0300
> Extend struct tcf_walker with additional 'cookie' field. It is intended to
> be used by classifier walk implementations to continue iteration directly
> from particular filter, instead of iterating 'skip' number of times.
>
> Change flower walk implementation to save filter handle in 'cookie'. Each
> time flower walk is called, it looks up filter with saved handle directly
> with idr, instead of iterating over filter linked list 'skip' number of
> times. This change improves complexity of dumping flower classifier from
> quadratic to linearithmic. (assuming idr lookup has logarithmic complexity)
>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
Applied, thank you.
Powered by blists - more mailing lists