netdev - Re: [PATCH bpf-next] tools: include reallocarray feature test in FEATURE_TESTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a41c96c0-b561-9a85-45a6-84471e3489ff@roeck-us.net>
Date:   Fri, 13 Jul 2018 19:26:48 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        alexei.starovoitov@...il.com, daniel@...earbox.net
Cc:     oss-drivers@...ronome.com, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] tools: include reallocarray feature test in
 FEATURE_TESTS_BASIC

On 07/13/2018 07:08 PM, Jakub Kicinski wrote:
> perf propagates its feature check results to libbpf.  This means
> features for which perf probes must be a superset of libbpf's
> required features.  perf depends on FEATURE_TESTS_BASIC for its list
> of features.
> 
> commit 531b014e7a2f ("tools: bpf: make use of reallocarray") added
> reallocarray use to libbpf, make perf also perform the reallocarray
> feature check.
> 
> Fixes: 531b014e7a2f ("tools: bpf: make use of reallocarray")
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Tested-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   tools/build/Makefile.feature | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index 5b6dda3b1ca8..f216b2f5c3d7 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -57,6 +57,7 @@ FEATURE_TESTS_BASIC :=                  \
>           libunwind-aarch64               \
>           pthread-attr-setaffinity-np     \
>           pthread-barrier     		\
> +        reallocarray                    \
>           stackprotector-all              \
>           timerfd                         \
>           libdw-dwarf-unwind              \
>