netdev - Re: [PATCH iproute2-next] ipaddress: fix label matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m3r2k5skyh.fsf@luffy.cx>
Date:   Sat, 14 Jul 2018 20:58:46 +0200
From:   Vincent Bernat <vincent@...nat.im>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        stephen@...workplumber.org
Subject: Re: [PATCH iproute2-next] ipaddress: fix label matching

 ❦ 14 juillet 2018 21:54 +0300, Serhey Popovych <serhe.popovych@...il.com> :

> We should leave only filter.label check and return 0:
>
>     if (filter.label)
>             return 0;
>
> This will ensure we exit from print_linkinfo() earlier, skip
> print_link_stats() and push final filtering by label to
> print_selected_addrinfo() and print_addrinfo().
>
> And finally: this is regression and should be against iproute2, not -next.

As you did the analysis, I let you do the patch.
-- 
Watch out for off-by-one errors.
            - The Elements of Programming Style (Kernighan & Plauger)