netdev - Re: [PATCH] net/rds: void function cannot return -1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df82aa42-133c-9381-ca97-1d80c8c3e3cc@oracle.com>
Date:   Mon, 16 Jul 2018 09:29:02 -0700
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Håkon Bugge <Haakon.Bugge@...cle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        rds-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/rds: void function cannot return -1

On 7/16/2018 6:00 AM, Håkon Bugge wrote:
> Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did
> not change the comment accordingly.
> 
> Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void")
> Signed-off-by: Håkon Bugge <haakon.bugge@...cle.com>
> ---
>   net/rds/ib_recv.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
> index b4e421aa9727..e5ce93419263 100644
> --- a/net/rds/ib_recv.c
> +++ b/net/rds/ib_recv.c
> @@ -376,8 +376,6 @@ static void release_refill(struct rds_connection *conn)
>    * This tries to allocate and post unused work requests after making sure that
>    * they have all the allocations they need to queue received fragments into
>    * sockets.
> - *
> - * -1 is returned if posting fails due to temporary resource exhaustion.
>    */
>   void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp)
>   {
> 
Yep. Thanks !!

Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.ccom>