netdev - Re: [PATCH 1/3] ravb: fix shadowing of symbol 'stats' in ravb_get_ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a68fdb02-c13b-25e1-922a-9e36f2f6f940@cogentembedded.com>
Date:   Mon, 16 Jul 2018 22:08:09 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>, netdev@...r.kernel.org
Cc:     linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 1/3] ravb: fix shadowing of symbol 'stats' in
 ravb_get_ethtool_stats()

On 07/16/2018 03:19 PM, Niklas Söderlund wrote:

> Inside a loop in ravb_get_ethtool_stats() a variable 'stats' is declared
> resulting in the argument also named 'stats' to be shadowed. Fix this
> warning by renaming the unused argument 'stats' to 'estats'.
> 
> This fixes the sparse warning:
> 
> ravb_main.c:1225:36: originally declared here
> ravb_main.c:1233:41: warning: symbol 'stats' shadows an earlier one
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
[...]

Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

MBR, Sergei